LiaCastaneda commented on code in PR #20542:
URL: https://github.com/apache/datafusion/pull/20542#discussion_r2852051394


##########
datafusion/functions/src/string/split_part.rs:
##########
@@ -341,6 +356,117 @@ mod tests {
             Utf8,
             StringArray
         );
+        // Edge cases with delimiters

Review Comment:
   wdyt about adding a couple of test cases for these edge cases in the 
[sqllogic 
tests](https://github.com/apache/datafusion/blob/e937cadbcceff6a42bee2c5fc8d03068fa0eb30c/datafusion/sqllogictest/test_files/string/string_literal.slt#L854)
 too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to