alamb commented on code in PR #20533:
URL: https://github.com/apache/datafusion/pull/20533#discussion_r2849612592
##########
datafusion/sqllogictest/test_files/array.slt:
##########
@@ -5181,12 +5181,12 @@ select cardinality(arrow_cast([[1, 2], [3, 4], [5, 6]],
'FixedSizeList(3, List(I
query II
select cardinality(make_array()), cardinality(make_array(make_array()))
Review Comment:
I also checked wiht postgres:
```sql
postgres=# select cardinality(ARRAY []::integer[]);
cardinality
-------------
0
(1 row)
```
##########
datafusion/sqllogictest/test_files/array.slt:
##########
@@ -5195,6 +5195,12 @@ NULL 0
#----
#NULL 0
+# cardinality of NULL arrays should return NULL
Review Comment:
This is also consistent with postgres:
```sql
postgres=# select cardinality(NULL::integer[]);
cardinality
-------------
(1 row)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
