LiaCastaneda opened a new pull request, #20499:
URL: https://github.com/apache/datafusion/pull/20499

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   - Closes #.
   
   ## Rationale for this change
   
   The following query is failing with the following error:
   
   `SELECT date_bin(NULL, TIMESTAMP '2023-01-01 12:30:00', TIMESTAMP 
'2023-01-01 12:00:00')
   `
   
   `Error: Error during planning: Failed to coerce arguments to satisfy a call 
to 'date_bin' function: coercion from Null, Timestamp(ns), Timestamp(ns) to the 
signature OneOf([....])`
   
   This is happening because NULL can not be matched to any of date_bin 
signatures, even though NULL can be casted to Interval in Arrow and every other 
type (integers, timestamps, floats) already had Null in its coercion rule.
   
   The standard PostgreSQL beaviour is to return NULL: 
https://www.db-fiddle.com/f/gpH2LkcVm2HrciT8ZzLLYU/0
   
   ## What changes are included in this PR?
   
   Fix `date_bin(NULL, ...)` to return `NULL` instead of a planning error by 
allowing Nulls to coerce to Interva.
   
   ## Are these changes tested?
   
   I added a sqllogictest case to verify the query executes and returns `NULL`.
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api 
change` label.
   -->
   
   Yes, previously `date_bin(NULL, ...) `returned a planning error. It now 
returns NULL.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to