andygrove commented on code in PR #506:
URL: https://github.com/apache/datafusion-comet/pull/506#discussion_r1677978125
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1703,18 +1703,21 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
optExprWithInfo(optExpr, expr, child)
}
+ /// The expression for `log` functions is defined as null on numbers
less than or equal
+ /// to 0. This matches Spark and Hive behavior, where non positive
values eval to null
+ /// instead of NaN or -Infinity
Review Comment:
CI is failing with scalastyle error `Insert a space after the start of the
comment` for these lines. Changing `///` to `//` should resolve it.
```suggestion
// The expression for `log` functions is defined as null on numbers
less than or equal
// to 0. This matches Spark and Hive behavior, where non positive
values eval to null
// instead of NaN or -Infinity
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
