KARTIK64-rgb commented on issue #19995:
URL: https://github.com/apache/datafusion/issues/19995#issuecomment-3939250792
Hi!
I’d love to be assigned to this issue.
I’ve reviewed the changes in #19881 and also looked at the relevant scripts
in the ClickHouse/ClickBench/tree/main/datafusion directory. Based on that,
here’s how I’m planning to approach the fix:
Proposed approach:
create.sql: Update the table definition so that EventDate is properly
registered or cast as a DATE type, instead of being treated as Int16 or UInt16.
run.sh / benchmark.sh: After loading the parquet file as hits_raw, create a
hits view that converts the raw UInt16 value (days since epoch) into a proper
SQL DATE using:
CAST(CAST("EventDate" AS INTEGER) AS DATE)
This follows the same pattern used in #19881.
queries.sql: Verify that queries 36–42, which rely on EventDate range
filters, work correctly with the updated DATE type.
This approach mirrors the fix in #19881 and should resolve the issue where
ClickBench queries 36–42 return 0 rows due to incorrect date comparisons.
I’d be happy to work on this — please assign it to me! 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
