alexander-beedie opened a new pull request, #2227: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2227
## Description * Tweaked `parse_expr_prefix_by_unreserved_word` to use `into_ident()` (move) instead of `to_ident()` (clone). * Added a `NoKeyword` fast path in `parse_prefix` (most column references are likely plain identifiers). ## Results Other benchmark tests just show noise (not really impacted by this change): ``` ┌──────────────────────────────┬───────────┬───────────┬────────┐ │ benchmark │ baseline │ this pr │ change │ ├──────────────────────────────┼───────────┼───────────┼────────┤ │ select_100_columns │ 67.93 µs │ 64.32 µs │ −5.1% │ ├──────────────────────────────┼───────────┼───────────┼────────┤ │ select_100_qualified_columns │ 140.92 µs │ 136.64 µs │ −3.0% │ ├──────────────────────────────┼───────────┼───────────┼────────┤ │ parse_large_statement │ 4.50 ms │ 4.47 ms │ −0.8% │ └──────────────────────────────┴───────────┴───────────┴────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
