Shekharrajak commented on code in PR #3558: URL: https://github.com/apache/datafusion-comet/pull/3558#discussion_r2835794155
########## spark/src/main/scala/org/apache/comet/iceberg/IcebergReflection.scala: ########## @@ -19,8 +19,167 @@ package org.apache.comet.iceberg +import java.lang.reflect.Method + import org.apache.spark.internal.Logging +/** + * Cache for Iceberg reflection metadata to avoid repeated class loading and method lookups. + * + * This cache is created once per serializePartitions() call and passed to helper methods. It + * provides ~50% serialization speedup by eliminating redundant reflection operations that would Review Comment: Cache at the right scope - Create cache once per serializePartitions() call, not per-task and Pass cache to helpers: Don't let helper methods do their own class loading -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
