mbutrovich commented on code in PR #3536:
URL: https://github.com/apache/datafusion-comet/pull/3536#discussion_r2835119622


##########
spark/src/test/scala/org/apache/comet/CometMathExpressionSuite.scala:
##########
@@ -92,7 +92,8 @@ class CometMathExpressionSuite extends CometTestBase with 
AdaptiveSparkPlanHelpe
       DataGenOptions(generateNegativeZero = generateNegativeZero))
   }
 
-  test("width_bucket") {
+  // https://github.com/apache/datafusion/issues/20320

Review Comment:
   Same comment about the closed PR.



##########
spark/src/main/spark-4.0/org/apache/comet/shims/CometExprShim.scala:
##########
@@ -104,9 +104,14 @@ trait CometExprShim extends CommonStringExprs {
         }
 
       case wb: WidthBucket =>
-        val childExprs = wb.children.map(exprToProtoInternal(_, inputs, 
binding))
-        val optExpr = scalarFunctionExprToProto("width_bucket", childExprs: _*)
-        optExprWithInfo(optExpr, wb, wb.children: _*)
+        withInfo(
+          wb,
+          "WidthBucket not supported, track 
https://github.com/apache/datafusion/issues/20320";)
+        None
+//        https://github.com/apache/datafusion/issues/20320

Review Comment:
   Same comment about the closed PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to