zhangxffff commented on code in PR #20444:
URL: https://github.com/apache/datafusion/pull/20444#discussion_r2833543369
##########
datafusion/physical-expr/benches/in_list.rs:
##########
@@ -50,7 +51,9 @@ fn random_string(rng: &mut StdRng, len: usize) -> String {
}
const IN_LIST_LENGTHS: [usize; 4] = [3, 8, 28, 100];
+const DYNAMIC_LIST_LENGTHS: [usize; 3] = [3, 8, 28];
Review Comment:
No, only column references trigger this code path. Heterogeneous literals
like 1 IN ('a', 1, 123.24) are type-coerced and still go through the static
(HashSet) path. Renamed to LIST_WITH_COLUMNS_LENGTHS, and also renamed all
related functions/benchmark names to remove the "dynamic" terminology.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
