2010YOUY01 commented on PR #11469: URL: https://github.com/apache/datafusion/pull/11469#issuecomment-2227809461
Thank you for the new feature, I have some thoughts for an alternative design: Recursive aggregate functions are generally unsupported: e.g. `select sum(sum(v1)) from t1` is not supported in DataFusion/Postgres/DuckDB. For this `unnest()` case, a recursive call is required, DuckDB uses: https://duckdb.org/docs/sql/query_syntax/unnest.html#recursive-unnest What do you think about implementing DuckDB syntax, I think it's better for: 1. Keep the SQL syntax consistent and avoid nested aggregate function 2. Avoid changing planner code (which might be error-prone), and keep the unnest logic within the aggregate function body -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
