andygrove commented on code in PR #3541:
URL: https://github.com/apache/datafusion-comet/pull/3541#discussion_r2828592776
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -1042,13 +1076,13 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
ignore("cast TimestampType to ShortType") {
// https://github.com/apache/datafusion-comet/issues/352
- // input: 2023-12-31 10:00:00.0, expected: -21472, actual: null]
Review Comment:
nit: this edit seems unrelated
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -1042,13 +1076,13 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
ignore("cast TimestampType to ShortType") {
// https://github.com/apache/datafusion-comet/issues/352
- // input: 2023-12-31 10:00:00.0, expected: -21472, actual: null]
+ // input: 2023-12-31 10:00:00.0, expected: -21472, actual: null
castTest(generateTimestamps(), DataTypes.ShortType)
}
ignore("cast TimestampType to IntegerType") {
// https://github.com/apache/datafusion-comet/issues/352
- // input: 2023-12-31 10:00:00.0, expected: 1704045600, actual: null]
+ // input: 2023-12-31 10:00:00.0, expected: 1704045600, actual: null
Review Comment:
nit: this edit seems unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
