rluvaton commented on code in PR #20308:
URL: https://github.com/apache/datafusion/pull/20308#discussion_r2824158713
##########
datafusion/functions/src/regex/mod.rs:
##########
@@ -65,6 +67,19 @@ pub mod expr_fn {
super::regexp_match().call(args)
}
+ /// Extracts a group that matches `regexp`. If `idx` is not specified,
+ /// it defaults to 1.
+ ///
+ /// Matches Spark's DataFrame API: `regexp_extract(e: Column, exp: String,
groupIdx: Int)`
Review Comment:
I agree but giving another perspective: it is useful to have a reference
implementation why it was like that, like we do for other functions that match
Postgres behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
