wiedld commented on PR #11444: URL: https://github.com/apache/datafusion/pull/11444#issuecomment-2226741174
> I wonder if we should make `ParquetOptions` be consistent with the `WriterOptions`? It seems like missing kv_metadata and column overrides might be an oversight rather than an intentional design) The `ParquetOptions` are explicitly stated as the global part of TableParquetOptions. https://github.com/apache/datafusion/blob/8f8df07c80aa66bb94d57c9619be93f9c3be92a9/datafusion/common/src/config.rs#L1396-L1397 Is there any reason to have the global ParquetOptions, without the TableParquetOptions? * the two additional fields are kv_metadata a col-specific hashmap, both of those can be default/empty. * proposal: can we make ParquetOptions be private to TableParquetOptions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
