comphead commented on code in PR #11415:
URL: https://github.com/apache/datafusion/pull/11415#discussion_r1676142947
##########
datafusion/core/src/datasource/file_format/write/orchestration.rs:
##########
@@ -50,7 +50,7 @@ pub(crate) async fn serialize_rb_stream_to_object_store(
mut data_rx: Receiver<RecordBatch>,
serializer: Arc<dyn BatchSerializer>,
mut writer: WriterType,
-) -> std::result::Result<(WriterType, u64), (WriterType, DataFusionError)> {
+) -> std::result::Result<(WriterType, u64), (Option<WriterType>,
DataFusionError)> {
Review Comment:
Perhaps it would be good for this PR to describe in docs what is what in
return megatype and later we can factor this out into separate strict type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
