jonathanc-n commented on code in PR #18392:
URL: https://github.com/apache/datafusion/pull/18392#discussion_r2771202164
##########
datafusion/physical-plan/src/joins/piecewise_merge_join/exec.rs:
##########
@@ -462,9 +446,35 @@ impl PiecewiseMergeJoinExec {
}
}
- // TODO
+ // Inner, Outer, Left, Right joins are swapped so that left side is larger
than right
+ // Left Semi/Anti joins are not swapped while Right Semi/Anti joins are
always swapped. This
Review Comment:
I'm going to include the comment in both places, just so anybody who reads
either function will understand the logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
