Kev1n8 commented on code in PR #11416:
URL: https://github.com/apache/datafusion/pull/11416#discussion_r1675691877
##########
datafusion/physical-plan/src/aggregates/topk/heap.rs:
##########
@@ -361,9 +385,9 @@ impl<VAL: ValueType> HeapItem<VAL> {
impl<VAL: ValueType> Debug for HeapItem<VAL> {
fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
f.write_str("bucket=")?;
- self.map_idx.fmt(f)?;
+ Debug::fmt(&self.map_idx, f)?;
Review Comment:
I think so. If it's not changed, the compiler will fail and report `fmt`
being ambiguous
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
