andygrove commented on code in PR #656:
URL: https://github.com/apache/datafusion-comet/pull/656#discussion_r1674727116
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -286,9 +286,10 @@ object CometConf extends ShimCometConf {
conf("spark.comet.explainFallback.enabled")
.doc(
"When this setting is enabled, Comet will provide logging explaining
the reason(s) " +
- "why a query stage cannot be executed natively.")
+ "why a query stage cannot be executed natively. Set this to false to
" +
Review Comment:
Other than the code that I introduced in this PR, which I am now going to
remove, the only calls to
`org.apache.comet.ExtendedExplainInfo#generateExtendedInfo` are from tests, so
the `COMET_EXPLAIN_VERBOSE_ENABLED` does not actually have any impact on end
users. Perhaps it should be marked as an internal config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
