danielhumanmod commented on code in PR #1361:
URL:
https://github.com/apache/datafusion-ballista/pull/1361#discussion_r2750285664
##########
ballista/scheduler/src/cluster/mod.rs:
##########
@@ -311,12 +313,15 @@ pub trait JobState: Send + Sync {
///
/// The job may not belong to the caller, and the graph may be updated
/// by another scheduler after this call returns.
- async fn get_execution_graph(&self, job_id: &str) ->
Result<Option<ExecutionGraph>>;
+ async fn get_execution_graph(
+ &self,
+ job_id: &str,
+ ) -> Result<Option<ExecutionGraphBox>>;
/// Persists the current state of an owned job.
Review Comment:
At first glance, the doc comment mentioning "Persists..." made me worried
about potential deserialization issues as we move to `Box`.
But after checking the codebase, I found `InMemoryJobState` is currently the
only implementation, so we should be good here.
BTW just curious, do we plan to support persistent storage for job state in
the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
