kumarUjjawal commented on PR #20073: URL: https://github.com/apache/datafusion/pull/20073#issuecomment-3827673434
> LGTM! > > It would be good to add some SLT tests though. There are only array based unit tests and there are no SLT tests. The Spark ones are empty - https://github.com/apache/datafusion/blob/f0de02fd664afcc4aad61fd8d13503533ed1e8d5/datafusion/sqllogictest/test_files/spark/string/chr.slt Thank you for the feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
