Jefffrey opened a new issue, #20089:
URL: https://github.com/apache/datafusion/issues/20089

   ### Is your feature request related to a problem or challenge?
   
   Currently `iszero()` and `isnan()` coerce inputs to float to compute:
   
   
https://github.com/apache/datafusion/blob/a02e6836e7d449008eef592b177ea282595e027a/datafusion/functions/src/math/iszero.rs#L61-L71
   
   
https://github.com/apache/datafusion/blob/a02e6836e7d449008eef592b177ea282595e027a/datafusion/functions/src/math/nans.rs#L57-L67
   
   ### Describe the solution you'd like
   
   Consider refactoring these to accept numeric types **without** coercing to 
float; the implementations should be simple (albeit verbose/tedious). For 
example, `isnan()` should return false for any numeric inputs that aren't float 
type, which might be a slight optimization.
   
   ### Describe alternatives you've considered
   
   If we prefer to keep the code simple we can leave it as is
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to