Jefffrey commented on issue #12709: URL: https://github.com/apache/datafusion/issues/12709#issuecomment-3827541318
Some pointers: Look here for the existing `StringConcat` operator: https://github.com/apache/datafusion/blob/a02e6836e7d449008eef592b177ea282595e027a/datafusion/expr-common/src/operator.rs#L83-L84 We should look at places it is used and either try to extend it to include binary (although it might be weird since the name is `StringConcat` unless we rename it) or potentially introduce a new operator `BinaryConcat`. We should also consider the UDF: https://github.com/apache/datafusion/blob/a02e6836e7d449008eef592b177ea282595e027a/datafusion/functions/src/string/concat.rs One thing to keep in mind is how we handle `binary || string` concat (i.e. which common type we coerce to); we can't assume all binary is a valid string, but strings are always valid binary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
