peter-toth commented on code in PR #11357:
URL: https://github.com/apache/datafusion/pull/11357#discussion_r1674238430
##########
datafusion/expr/src/expr.rs:
##########
@@ -1401,6 +1401,41 @@ impl Expr {
.expect("traversal is infallable");
}
+ /// Return all references to columns and their occurrence counts in the
expression.
+ ///
+ /// # Example
+ /// ```
+ /// # use std::collections::HashMap;
+ /// # use datafusion_common::Column;
+ /// # use datafusion_expr::col;
+ /// // For an expression `a + (b * a)`
+ /// let expr = col("a") + (col("b") * col("a"));
+ /// let mut refs = expr.column_refs_counts();
+ /// // refs contains "a" and "b"
+ /// assert_eq!(refs.len(), 2);
+ /// assert_eq!(*refs.get(&Column::new_unqualified("a")).unwrap(), 2);
+ /// assert_eq!(*refs.get(&Column::new_unqualified("b")).unwrap(), 1);
+ /// ```
+ pub fn column_refs_counts(&self) -> HashMap<&Column, usize> {
+ let mut map = HashMap::new();
+ self.add_column_ref_counts(&mut map);
+ map
+ }
+
+ /// Adds references to all columns and their occurrence counts in the
expression to
+ /// the map.
+ ///
+ /// See [`Self::column_refs`] for details
Review Comment:
Thanks, fixed in
https://github.com/apache/datafusion/pull/11357/commits/17f33f7d376fd61f82334d680e2943747d11fd67.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
