karuppuchamysuresh opened a new pull request, #20072:
URL: https://github.com/apache/datafusion/pull/20072

   ## Which issue does this PR close?                                           
                                                                                
                                                                                
      
                                                                                
                                                                                
                                                                                
        
     - Closes #18314                                                            
                                                                                
                                                                                
        
                                                                                
                                                                                
                                                                                
        
     ## Rationale for this change                                               
                                                                                
                                                                                
        
                                                                                
                                                                                
                                                                                
        
     The documentation in `data_types.md` was outdated and showed `Utf8` as the 
default mapping for character types (CHAR, VARCHAR, TEXT, STRING), but the 
current implementation defaults to `Utf8View`. This caused confusion for users 
reading the   
     documentation as it didn't match the actual behavior.                      
                                                                                
                                                                                
        
                                                                                
                                                                                
                                                                                
        
     Additionally, the "Supported Arrow Types" section at the end was redundant 
since `arrow_typeof` now supports all Arrow types, making the comprehensive 
list unnecessary.                                                               
            
                                                                                
                                                                                
                                                                                
        
     ## What changes are included in this PR?                                   
                                                                                
                                                                                
        
                                                                                
                                                                                
                                                                                
        
     1. **Updated Character Types table**: Changed the Arrow DataType column 
from `Utf8` to `Utf8View` for CHAR, VARCHAR, TEXT, and STRING types             
                                                                                
           
     2. **Added configuration note**: Documented the 
`datafusion.sql_parser.map_string_types_to_utf8view` setting that allows users 
to switch back to `Utf8` if needed                                              
                                    
     3. **Removed outdated section**: Deleted the "Supported Arrow Types" 
section (39 lines) as it's no longer necessary                                  
                                                                                
              
                                                                                
                                                                                
                                                                                
        
     ## Are these changes tested?                                               
                                                                                
                                                                                
        
                                                                                
                                                                                
                                                                                
        
     This is a documentation-only change. The documentation accurately reflects 
the current behavior of DataFusion:                                             
                                                                                
        
     - The default mapping to `Utf8View` is the current implementation behavior 
                                                                                
                                                                                
        
     - The `datafusion.sql_parser.map_string_types_to_utf8view` configuration 
option exists and works as documented                                           
                                                                                
          
                                                                                
                                                                                
                                                                                
        
     ## Are there any user-facing changes?                                      
                                                                                
                                                                                
        
                                                                                
                                                                                
                                                                                
        
     Yes, documentation changes only. Users will now see accurate information 
about:                                                                          
                                                                                
          
     - The correct default Arrow type mappings for character types              
                                                                                
                                                                                
        
     - How to configure the string type mapping behavior if they need the old 
`Utf8` behavior 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to