2010YOUY01 commented on PR #20023: URL: https://github.com/apache/datafusion/pull/20023#issuecomment-3816515880
> I’ve also cleaned up the imports and resolved the linting issues. I’m genuinely interested in improving DataFusion's performance here and would appreciate a fresh review of these technical changes. I do appreciate your efforts, but I don’t think it’s possible to optimize what you don't understand, even with the help of AI tools. I think we should refine the AI guide to better explain why this won't help. Perhaps you could share why you think this would help, and which part of the AI guide doesn’t make sense to you. I’ll try to clarify and explain it better in: https://datafusion.apache.org/contributor-guide/index.html#why-fully-ai-generated-prs-without-understanding-are-not-helpful Perhaps it's defining more clearly what “understanding the core ideas” means. For optimizations, I believe you should start from a motivating workload, show that the change makes it faster, and be able to explain the internal machinery involved for that query and why the change improves it. I don’t think “this piece of code looks slow” is a legitimate motivation for an optimization, unless it is an obviously redundant step. That doesn’t seem to be the case for the large-scale change in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
