alamb commented on code in PR #11392:
URL: https://github.com/apache/datafusion/pull/11392#discussion_r1672863659
##########
datafusion/expr/src/udaf.rs:
##########
@@ -72,20 +76,19 @@ pub struct AggregateUDF {
impl PartialEq for AggregateUDF {
fn eq(&self, other: &Self) -> bool {
- self.name() == other.name() && self.signature() == other.signature()
+ self.inner.equals(other.inner.as_ref()) ||
other.inner.equals(self.inner.as_ref())
Review Comment:
I think comparing the inner function is the most straightforward... However,
you are right that it does seem like it should be comparing the aliases too
probably
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
