berkaysynnada commented on PR #11333: URL: https://github.com/apache/datafusion/pull/11333#issuecomment-2216857903
> @berkaysynnada, could you please help review this? Thanks for investigating those issues, @jonahgao. Great catch and fix. I have searched for other instances of name equalities and found another one. Would you prefer updating this part as well? https://github.com/apache/datafusion/blob/4123ad6ca7bb7bdcb4cca65e97d30b4677233de3/datafusion/core/src/physical_optimizer/projection_pushdown.rs#L1132 to `column.name() == proj_column.name() && column.index() + offset == proj_column.index()` where `offset` is the length of fields of the left child, similar to your fix. If you prefer not to, I can open another small PR for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
