alamb commented on code in PR #11307:
URL: https://github.com/apache/datafusion/pull/11307#discussion_r1667733900
##########
datafusion/core/tests/user_defined/user_defined_sql_planner.rs:
##########
@@ -86,3 +97,27 @@ async fn test_custom_operators_long_arrow() {
];
assert_batches_eq!(&expected, &actual);
}
+
+#[tokio::test]
+async fn test_question_sekect() {
Review Comment:
Is it a typo?
```suggestion
async fn test_question_select() {
```
##########
datafusion/core/tests/user_defined/user_defined_sql_planner.rs:
##########
@@ -86,3 +97,27 @@ async fn test_custom_operators_long_arrow() {
];
assert_batches_eq!(&expected, &actual);
}
+
+#[tokio::test]
+async fn test_question_sekect() {
Review Comment:
I verified this test fails like this without this PR's changes:
```
---- user_defined::user_defined_sql_planner::test_question_filter stdout ----
thread 'user_defined::user_defined_sql_planner::test_question_filter'
panicked at
datafusion/core/tests/user_defined/user_defined_sql_planner.rs:120:10:
called `Result::unwrap()` on an `Err` value: Plan("Attempted to create
Filter predicate with expression `Boolean(true)` aliased as 'a ? Int64(2)'.
Filter predicates should not be aliased.")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
