xinlifoobar commented on code in PR #11263:
URL: https://github.com/apache/datafusion/pull/11263#discussion_r1666303788
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -170,6 +170,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
schema: &DFSchema,
planner_context: &mut PlannerContext,
) -> Result<Expr> {
+ let sql_not_moved = sql.clone();
Review Comment:
Using references is also bad. The code moves fields from
sqlparser::ast::Expr everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
