alamb commented on code in PR #11225:
URL: https://github.com/apache/datafusion/pull/11225#discussion_r1664773449
##########
ci/scripts/rust_example.sh:
##########
@@ -19,7 +19,6 @@
set -ex
cd datafusion-examples/examples/
-cargo fmt --all -- --check
Review Comment:
why remove this? I think it is intended to ensure that cargo fmt is run on
the examples.
##########
datafusion-examples/README.md:
##########
@@ -35,6 +35,9 @@ cd datafusion
# Download test data
git submodule update --init
Review Comment:
I tested this locally and the existing command (in the main datafusion
directory) also seems to work fine
```
~/Software/datafusion2$ cargo run --example csv_sql
Running `target/debug/examples/csv_sql`
+----+-----------------------------+-----------------------------+
| c1 | MIN(aggregate_test_100.c12) | MAX(aggregate_test_100.c12) |
+----+-----------------------------+-----------------------------+
| c | 0.2667177795079635 | 0.991517828651004 |
| a | 0.02182578039211991 | 0.9567595541247681 |
| b | 0.04893135681998029 | 0.9185813970744787 |
| e | 0.01479305307777301 | 0.9965400387585364 |
| d | 0.061029375346466685 | 0.9748360509016578 |
+----+-----------------------------+-----------------------------+
+----+------+
| c2 | c3 |
+----+------+
| 1 | -85 |
| 3 | 13 |
| 4 | -38 |
| 4 | -54 |
| 5 | 36 |
| 1 | -25 |
| 5 | -31 |
| 2 | 45 |
| 3 | 13 |
| 3 | 17 |
| 4 | 65 |
| 4 | -101 |
| 2 | -48 |
| 1 | -56 |
| 1 | -5 |
| 3 | 14 |
| 1 | 83 |
| 3 | -12 |
| 3 | -72 |
| 2 | -43 |
| 5 | -101 |
+----+------+
```
It does also work in `datafusion-examples/examples`/ but `cd`ing into that
directory seems unecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
