MohamedAbdeen21 commented on code in PR #11186:
URL: https://github.com/apache/datafusion/pull/11186#discussion_r1662866175
##########
datafusion/sql/src/unparser/expr.rs:
##########
@@ -618,6 +681,50 @@ impl Unparser<'_> {
}
}
+ // TODO: operator precedence should be defined in sqlparser
Review Comment:
No, it uses DF operator precedence. As sqlparser operators don't have
precedence defined, we first map the sqlparser operators to DF operators;
that's what the sql_to_op below is for.
If we can define precedence on sqlparser ops directly, we can remove both of
these methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
