Rachelint commented on PR #11147: URL: https://github.com/apache/datafusion/pull/11147#issuecomment-2203194934
Thanks for > Thanks @Rachelint -- this is great. > > > Remember to add the test in roundtrip_expr_api in datafusion/proto/tests/cases/roundtrip_logical_plan.rs, others LGTM. > > As I am slightly panicng about the size of the review queue, I took the liberty of adding this test myself and merging up from main Thanks @alamb for helping, and sorry for the delay. Thanks for review @jayzhan211 @dharanad -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
