alamb commented on issue #9375: URL: https://github.com/apache/datafusion/issues/9375#issuecomment-2191659377
> we could restrict the minimum elements of CommutativeExpr to 3. That could make sense My biggest concern with this proposal is its potential impact on backwards compatibility / causing API churn to solve a very narrow usecase I wonder if you have considered the approach to turning a stack overflow into an error? So like maybe add a configuration flag like "max_expression_depth = 10" or something and then if that depth is exceeded in `SqlToRel` raise an error? That would protect against crashes/ stack overflows but still allow people who wanted more complex expressions (and were willing to raise their stack sizes) to run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
