alamb commented on code in PR #10893: URL: https://github.com/apache/datafusion/pull/10893#discussion_r1638363273
########## datafusion/expr/src/aggregate_function.rs: ########## @@ -33,8 +33,6 @@ use strum_macros::EnumIter; // https://datafusion.apache.org/contributor-guide/index.html#how-to-add-a-new-aggregate-function #[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Hash, EnumIter)] pub enum AggregateFunction { - /// Count Review Comment: Perhaps that is how PRs like https://github.com/apache/datafusion/pull/10898 show up -- I can't keep up anymore. Thanks @jayzhan211 -- really nice -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
