viirya commented on code in PR #10892:
URL: https://github.com/apache/datafusion/pull/10892#discussion_r1637138336
##########
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##########
@@ -860,6 +867,8 @@ impl SMJStream {
self.reservation.shrink(buffered_batch.size_estimation);
}
} else {
+ // If the head batch is not fully processed, break
the loop.
+ // Streamed batch will be joined with the head
batch in the next step.
Review Comment:
Not related to this issue. But as I re-read these code, I add some comments
to help us understand it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
