advancedxy commented on issue #547: URL: https://github.com/apache/datafusion-comet/issues/547#issuecomment-2162006398
Linking this to #517 too. > Are we expecting a performance improvement as a result? (I doubt stack allocations are a performance bottleneck) +1. I think we may need to figure out the root cause first. It might that the implementation of `XxHash64` introduces some performance bottleneck, rather the stack allocation. I can try to reproduce and check this issue this weekend if I have some spare time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
