andygrove commented on code in PR #544:
URL: https://github.com/apache/datafusion-comet/pull/544#discussion_r1633625754
##########
core/src/errors.rs:
##########
@@ -184,11 +185,18 @@ impl convert::From<Box<dyn Any + Send>> for CometError {
}
}
}
-
+impl From<DataFusionError> for CometError {
+ fn from(value: DataFusionError) -> Self {
+ CometError::DataFusion {
+ msg: value.message().to_string(),
+ source: value,
+ }
+ }
+}
Review Comment:
nit: looks like we need some blank lines to separate this block
```suggestion
impl From<DataFusionError> for CometError {
fn from(value: DataFusionError) -> Self {
CometError::DataFusion {
msg: value.message().to_string(),
source: value,
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
