tinfoil-knight commented on code in PR #9723:
URL: https://github.com/apache/datafusion/pull/9723#discussion_r1632994244
##########
datafusion/sql/src/statement.rs:
##########
@@ -850,7 +850,16 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
return plan_err!("Unsupported Value in COPY statement {}",
value);
}
};
- options.insert(key.to_lowercase(), value_string.to_lowercase());
+ if !(&key.contains('.')) {
+ // If config does not belong to any namespace, assume it is
+ // a format option and apply the format prefix for backwards
+ // compatibility.
+
+ let renamed_key = format!("format.{}", key);
+ options.insert(renamed_key.to_lowercase(),
value_string.to_lowercase());
Review Comment:
The change was originally added in this PR:
https://github.com/apache/datafusion/pull/9382
It seems like the author of that PR was trying to consolidate case changes
(using `to_lowercase`) in multiple places to just a single place.
For now, you could add an exclusion for the access token option that is case
sensitive in your PR so you can continue your work.
Ideally, we should probably stop lower-casing the options and handle
case-sensitivity in the specific reader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
