andygrove commented on code in PR #513:
URL: https://github.com/apache/datafusion-comet/pull/513#discussion_r1631518775
##########
core/src/execution/datafusion/expressions/scalar_funcs.rs:
##########
@@ -130,6 +133,10 @@ pub fn create_comet_physical_fun(
let func = Arc::new(spark_xxhash64);
make_comet_scalar_udf!("xxhash64", func, without data_type)
}
+ "chr" => {
Review Comment:
I suppose it would be possible to build an `If(child == lit(0), lit("0"),
chr(child))` but seems like that would add more runtime overhead and complexity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
