jayzhan211 commented on code in PR #10807:
URL: https://github.com/apache/datafusion/pull/10807#discussion_r1630411768
##########
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##########
@@ -861,105 +861,6 @@ mod test {
assert_eq!(expected, formatted_plan);
}
- #[test]
- fn id_array_visitor() -> Result<()> {
Review Comment:
> for example we could add a sum() AggregateUDF that had the same signature
as sum
Introduce another similar function for test only increase the maintain cost
unless they are not changed frequently 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
