parthchandra commented on code in PR #529:
URL: https://github.com/apache/datafusion-comet/pull/529#discussion_r1629980987
##########
core/src/execution/datafusion/expressions/cast.rs:
##########
@@ -19,6 +19,7 @@ use std::{
any::Any,
fmt::{Debug, Display, Formatter},
hash::{Hash, Hasher},
+ num::Wrapping,
Review Comment:
Wonder if this is also faster since there is no overflow check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
