devinjdangelo opened a new pull request, #10788: URL: https://github.com/apache/datafusion/pull/10788
## Which issue does this PR close? none ## Rationale for this change I noticed while working on #10767 some unparser methods have grown unwieldy and difficult to understand. This PR attempts to break some of the more confusing methods up with the aim of making them more easily readable. ## What changes are included in this PR? - Break up handling of `LogicalPlan::Projection` nodes in `select_to_sql_recursively` into multiple helpers - Rewrite `find_agg_node_within_select` to use a `match` statement rather than several `if let`s ## Are these changes tested? Yes, by existing tests (no new features or bug fixes in this PR) ## Are there any user-facing changes? No, purely reorganizing code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
