waynexia commented on code in PR #10742:
URL: https://github.com/apache/datafusion/pull/10742#discussion_r1622515411
##########
datafusion/physical-expr-common/src/aggregate/mod.rs:
##########
@@ -185,6 +185,41 @@ pub trait AggregateExpr: Send + Sync + Debug +
PartialEq<dyn Any> {
fn create_sliding_accumulator(&self) -> Result<Box<dyn Accumulator>> {
not_impl_err!("Retractable Accumulator hasn't been implemented for
{self:?} yet")
}
+
+ /// Returns all expressions used in the [`AggregateExpr`].
+ /// First entry in the tuple corresponds to function arguments
+ /// Second entry in the tuple corresponds to order by expressions.
Review Comment:
nit: you have defined a struct for return type XD
The same to `WindowPhysicalExpressions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
