alamb commented on code in PR #10622:
URL: https://github.com/apache/datafusion/pull/10622#discussion_r1611490277
##########
datafusion/substrait/src/logical_plan/producer.rs:
##########
@@ -2125,6 +2141,15 @@ mod test {
),
)))?;
+ let struct_field_1 = Field::new("c0", DataType::Boolean, true);
+ let struct_field_2 = Field::new("c1", DataType::Int32, true);
+ round_trip_literal(
Review Comment:
I suggest one more test with null values too -- specifically something like
```rust
ScalarStructBuilder::new()
.with_scalar(struct_field_1, ScalarValue::Boolean(None))
.with_scalar(struct_field_2, ScalarValue::Int32(None))
.build()?,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
