viirya commented on code in PR #460:
URL: https://github.com/apache/datafusion-comet/pull/460#discussion_r1610733007
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -724,89 +700,80 @@ class CometSparkSessionExtensions
}
// We shouldn't transform Spark query plan if Comet is disabled.
- if (!isCometEnabled(conf)) return plan
-
- if (!isCometExecEnabled(conf)) {
- // Comet exec is disabled, but for Spark shuffle, we still can use
Comet columnar shuffle
- if (isCometShuffleEnabled(conf)) {
- applyCometShuffle(plan)
- } else {
- plan
- }
Review Comment:
I think with native execution gets more mature, it will be very rare we
would like to disable native execution but trigger Comet shuffle. This is not
necessary anymore so delete it to make code clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
