erratic-pattern commented on code in PR #10473:
URL: https://github.com/apache/datafusion/pull/10473#discussion_r1605591431
##########
datafusion/expr/src/expr.rs:
##########
@@ -1389,6 +1390,201 @@ impl Expr {
| Expr::Placeholder(..) => false,
}
}
+
+ pub fn hash_node(&self, hasher: &mut AHasher) {
Review Comment:
`std::mem::discriminant(self).hash(hasher)` would replace all of the
`hasher.write_u8(incrementing_number)` calls with something that is less
error-prone and more robust to API changes. The rest of the hashing logic would
be unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
