NGA-TRAN commented on PR #10537: URL: https://github.com/apache/datafusion/pull/10537#issuecomment-2118417052
@alamb : The PR is ready for review. Some notes: 1. The tests in `datafusion/core/src/datasource/physical_plan/parquet/statistics.rs` are tests for different dat types. Instead of using exact test inputs that do not cover everything, I am reusing a general available test inputs. Since I have not added all data types (which we agreed to do in a follow-on PR to avoid too much code), I decided not to remove any tests from that file yet. Will remove them when I am happy with the test coverage. 2. I have a feeling there will be a lot of tests of we want to cover all data types. I am looking froward to your feedback of tests in this PR for what we should not add. 3. I found a bug (the same for 3 tests in 3 different data types). I did a quick investigation but not very clear the root cause yet. I will do it next week -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
