berkaysynnada commented on code in PR #10510:
URL: https://github.com/apache/datafusion/pull/10510#discussion_r1602655825
##########
datafusion/expr/src/interval_arithmetic.rs:
##########
@@ -1469,6 +1472,8 @@ pub enum NullableInterval {
MaybeNull { values: Interval },
/// The value is definitely not null, and is within the specified range.
NotNull { values: Interval },
+ /// Added to handle cases with insufficient statistics
+ Unknown,
}
Review Comment:
> Anywhere we have `ColumnStatistics` we should also have the schema (and
thus the `DataType` of all columns) -- maybe we just have to pass the schema
along with the statistics?
Yes, I think that's the right approach for this issue. Can we open a ticket
for this? It should be an easy fix, and `ColumnStatistics` isn't used in many
parts of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
