jayzhan211 commented on code in PR #10492:
URL: https://github.com/apache/datafusion/pull/10492#discussion_r1600793234
##########
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -622,8 +622,8 @@ async fn roundtrip_expr_api() -> Result<()> {
),
array_replace_all(make_array(vec![lit(1), lit(2), lit(3)]), lit(2),
lit(4)),
first_value(vec![lit(1)], false, None, None, None),
- covar_samp(lit(1.5), lit(2.2), false, None, None, None),
Review Comment:
> This change now means the expr_fn can't be used with ordering /
null_treatment right? I think that is probably ok
>
> Perhaps we can consider some better API for creating aggregate functions
with `ORDER BY`, perhaps inspired by #6747
>
> Perhaps something like
>
> ```rust
> // form `FIRST_VALUE(a ORDER BY b)`
> let agg_expr = AggregateUDF::call(first_value())
> .args(col("a"))
> .order_by(vec![col("b"))
> .build()?;
> ```
This looks nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
