Michael-J-Ward commented on code in PR #693: URL: https://github.com/apache/datafusion-python/pull/693#discussion_r1600269923
########## src/functions.rs: ########## @@ -474,6 +474,7 @@ expr_fn!( ); expr_fn!(sqrt, num); expr_fn!(starts_with, arg1 arg2, "Returns true if string starts with prefix."); +expr_fn!(ends_with, arg1 arg2, "Returns true if string ends with suffix."); Review Comment: We should probably match the argument names to upstream: `string suffix` (I assume you just matched what `starts_with` has. That was either my error as I made the initial port or the upstream UDF changed) https://docs.rs/datafusion/latest/datafusion/functions/expr_fn/fn.ends_with.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
