comphead commented on code in PR #10495:
URL: https://github.com/apache/datafusion/pull/10495#discussion_r1600249575
##########
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##########
@@ -1323,7 +1323,9 @@ impl SMJStream {
// If join filter exists, `self.output_size` is not accurate as we
don't know the exact
// number of rows in the output record batch. If streamed row joined
with buffered rows,
// once join filter is applied, the number of output rows may be more
than 1.
- if record_batch.num_rows() > self.output_size {
+ // If `record_batch` is empty, we should reset `self.output_size` to
0. It could be happened
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
